[PATCH] D112753: [llvm] [Support] Add CURL HTTP Client.

[Noah Shutty via Phabricator via llvm-commits]

noajshu added inline comments.


================
Comment at: llvm/lib/Support/InitLLVM.cpp:63
+
+  if (HTTPClient::isAvailable())
+    HTTPClient::initialize();
----------------
dblaikie wrote:
> Does "isAvailable" need to be checked? The non-curl implementation doesn't fail on initialize or cleanup, I think? It's just a no-op there. So maybe calling these without the conditionality would be OK?
Thanks, indeed, good point. I removed this and only declare `IsInitialized` when the curl client is enabled since it serves no purpose for the "unimplemented" form of the HTTP client.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112753/new/

https://reviews.llvm.org/D112753