[PATCH] D113613: [ThinLTO][MC] Use conditional assignments for promotion aliases

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/test/MC/ELF/set-conditional.s:1
+// RUN: llvm-mc -triple x86_64-pc-linux-gnu < %s | FileCheck %s
+// RUN: not llvm-mc -filetype=obj -triple x86_64-pc-linux-gnu --defsym ERR=1 %s 2>&1 |\
----------------
You can use `# `, which is shorter.


================
Comment at: llvm/test/MC/ELF/set-conditional.s:4
+// RUN:         FileCheck %s --check-prefix=ERR
+
+// CHECK: .set b, a
----------------
It is unclear what `.set_conditional` are passed through.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113613/new/

https://reviews.llvm.org/D113613