[PATCH] D113968: [fir] Add fircg.ext_array_coor conversion

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan added inline comments.


================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:1471
+        // as below, as the LLVM struct type cannot be statically defined.
+        return rewriter.notifyMatchFailure(
+            coor, "derived type with type parameters not implemented yet");
----------------
Please replace back with TODO.
See discussion in https://reviews.llvm.org/D114104#inline-1089507


================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:1506
+          return rewriter.notifyMatchFailure(
+              coor, "compute size of derived type with type parameters not "
+                    "implemented yet");
----------------
Please replace back with TODO.
See discussion in https://reviews.llvm.org/D114104#inline-1089507


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113968/new/

https://reviews.llvm.org/D113968