[PATCH] D114154: [fir] Add fir.no_reassoc conversion

Eric Schweitz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 18 14:57:58 PST 2021


schweitz added inline comments.


================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:1131-1132
+                  mlir::ConversionPatternRewriter &rewriter) const override {
+    rewriter.replaceOp(noreassoc, adaptor.getOperands()[0]);
+    return success();
+  }
----------------
kiranchandramohan wrote:
> Does lowering generate this operation now? If not then notifyMatchFailure would be better here.
Yes. It does.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114154/new/

https://reviews.llvm.org/D114154



More information about the llvm-commits mailing list