[PATCH] D112758: [llvm] [Debuginfo] Debuginfod client library.

[Petr Hosek via Phabricator via llvm-commits]

phosek added inline comments.


================
Comment at: llvm/include/llvm/Debuginfod/Debuginfod.h:40
+// directory and server URLs.
+Expected<std::string> getCachedOrDownloadSource(StringRef BuildID,
+                                                StringRef SourceFilePath);
----------------
I'd consider using `const ArrayRef<uint8_t> BuildID` and do the conversion to string internally (in which case even `buildIDToString` could be an internal function).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112758/new/

https://reviews.llvm.org/D112758