[PATCH] D114128: [SROA] Add an IR to test that allocations of struct are scalarized.

Mingming Liu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 18 13:43:24 PST 2021


luna marked 10 inline comments as done.
luna added a comment.

In D114128#3140590 <https://reviews.llvm.org/D114128#3140590>, @lebedev.ri wrote:

> (disclaimer for the change itself: note that it is not sufficient to check that there are scalar loads/stores, it'd miss the point of SROA.)

It's true. This test is added with the goal to demonstrate how current sroa works, and for a planned patch, it will slightly change the scalarization, so this IR will be updated.



================
Comment at: llvm/test/Transforms/SROA/alloca-struct.ll:1
+; RUN: opt < %s -sroa -S | FileCheck %s
+; RUN: opt < %s -passes=sroa -S | FileCheck %s
----------------
lebedev.ri wrote:
> Please just use auto-update test like in the other tests here
Some unit tests run the auto-update while others doesn't (e.g., https://github.com/llvm/llvm-project/blob/main/llvm/test/Transforms/SROA/fca.ll is not updated by auto-updater)

For this IR, using auto-updater inserts quite many checker lines and somewhat hard to read. So will keep the current format.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114128/new/

https://reviews.llvm.org/D114128



More information about the llvm-commits mailing list