[PATCH] D114190: [SLP][NFC]Introduce TreeEntry::getVectorFactor member function, NFC.

Vasileios Porpodas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 18 13:41:06 PST 2021


vporpo added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:1683
 
+    /// \return Final vectorization factor for the node.
+    unsigned getVectorFactor() const {
----------------
"Final" is a bit ambiguous, could you explain a bit more in the comment what this refers to? My understanding is that this refers to the VF used when we generated code, and it may differ from Scalars.size() if this node contains scalars that repeat.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114190/new/

https://reviews.llvm.org/D114190



More information about the llvm-commits mailing list