[PATCH] D103991: [SCEV] Move mustprogress based no-self-wrap logic so it applies to all exit conditions

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

In D103991#3141054 <https://reviews.llvm.org/D103991#3141054>, @reames wrote:

> In D103991#3140961 <https://reviews.llvm.org/D103991#3140961>, @nikic wrote:
>
>> Looks like this caused an unexpected compile-time regression: https://llvm-compile-time-tracker.com/compare.php?from=7a14244cc645bbbcbf5056e7a00fadbb339e92ed&to=ea12c2cb9c4221095abfb2af7148140783040734&stat=instructions +1.5% on mafft.
>
> Your right, that is unexpected.  I don't really see anything in this code likely to be slow, do you see anything obvious?  If not, I may need help testing a few variants to see what we see.
>
> Any evidence on impact?  Are we transforming those benchmarks more?

There is some impact, but it's very minor: https://llvm-compile-time-tracker.com/compare.php?from=7a14244cc645bbbcbf5056e7a00fadbb339e92ed&to=ea12c2cb9c4221095abfb2af7148140783040734&stat=size-text

I don't immediately see what could cause this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103991/new/

https://reviews.llvm.org/D103991