[PATCH] D96914: [ELF] Add -z start-stop-gc to let __start_/__stop_ not retain C identifier name sections

Thu Nov 18 12:49:35 PST 2021

MaskRay added a comment.

In D96914#3140341 <https://reviews.llvm.org/D96914#3140341>, @tstellar wrote:

> We need to come to some kind of a consensus here.  I think since this patch was approved on the condition that the default not change, we really need to revert the new default behavior.  Here is my proposal:
>
> 1. Add a CMake option to allow users to opt-in to the new behavior, but the default value for this option should be the old behavior.
> 2. Start a thread on llvm-dev to discuss this change and a possible migration plan.
> 3. Make the same change in release/13.x
>
> @MaskRay I know this is an important feature, but we must follow LLVM process here.   6d2d3bd0a61f5fc7fd9f61f48bc30e9ca77cc619 <https://reviews.llvm.org/rG6d2d3bd0a61f5fc7fd9f61f48bc30e9ca77cc619> was committed without review and with @jrtc27 nak'ing it the discussion of D96914 <https://reviews.llvm.org/D96914>.  I think the CMake option is a good compromise.  Are you able to make this change?

I think an opt-out CMake option is fine. I created D114186 <https://reviews.llvm.org/D114186>

6d2d3bd0a61f5fc7fd9f61f48bc30e9ca77cc619 <https://reviews.llvm.org/rG6d2d3bd0a61f5fc7fd9f61f48bc30e9ca77cc619> is not new behavior at all. It is what GNU ld<2015-10 does.
See https://reviews.llvm.org/D96914#3128046 and my previous comments.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96914/new/

https://reviews.llvm.org/D96914