[PATCH] D111288: [fir] Add data flow optimization pass

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: flang/test/Fir/memref-data-flow.fir:82
+
+func @forward_store1(%arg0: !fir.ref<!fir.array<?xi32>>, %arg1: !fir.ref<!fir.array<?xi32>>, %arg2: !fir.ref<!fir.array<?xi32>>, %arg3: !fir.ref<i32>) {
+  %c1_i64 = arith.constant 1 : i64
----------------
What kind of pattern this function is exercising that isn't exercised by other tests?

I don't know what forward_store0 is covering compared to forward_store1...

(same question for forward_store2, forward_store3...)


================
Comment at: flang/test/Fir/memref-data-flow.fir:155
+// CHECK-LABEL:  ^bb6:
+// CHECK-NOT       fir.store %{{.*}} to %{{.*}} : !fir.ref<i32>
+
----------------
This sequence of checks is fairly obscure to me.

(same below)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111288/new/

https://reviews.llvm.org/D111288