[PATCH] D114172: [ARM] implement support for ALU PC-relative group relocations

[Peter Smith via Phabricator via llvm-commits]

peter.smith added a comment.

At a glance this looks good to me. I've not gone through all the fine details of the calculation and the tests yet. I'll be out of office tomorrow so likely to be next week. Happy for someone else to approve in my absence. I agree with you that no-one should be relying on the wrap around case for an address calculation. The original code was taken from the ARM backend to make it easier to review as it had been used elsewhere in the code-base for many years.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114172/new/

https://reviews.llvm.org/D114172