[PATCH] D114159: [flang][codegen] Add a conversion for `fir.coordinate_of` - part 1

Andrzej Warzynski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 18 09:01:52 PST 2021


awarzynski updated this revision to Diff 388228.
awarzynski marked 5 inline comments as done.
awarzynski added a comment.

Address PR comments (remove `auto`, replace "magic numbers" with variables, switch to `notifyMatchFailure` in place of `mlir::emitError`)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114159/new/

https://reviews.llvm.org/D114159

Files:
  flang/lib/Optimizer/CodeGen/CodeGen.cpp
  flang/lib/Optimizer/CodeGen/TypeConverter.h
  flang/test/Fir/convert-to-llvm-invalid.fir
  flang/test/Fir/convert-to-llvm.fir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D114159.388228.patch
Type: text/x-patch
Size: 24277 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211118/fe757120/attachment-0001.bin>


More information about the llvm-commits mailing list