[PATCH] D114159: [flang][codegen] Add a conversion for `fir.coordinate_of` - part 1

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan added a comment.

A few nit comments.



================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:2125
+    if (fir::hasDynamicSize(fir::unwrapSequenceType(objectTy)))
+      return mlir::emitError(
+          loc,
----------------
Nit: use NotifyMatchfailure


================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:2151
+
+    return mlir::emitError(
+        loc, "fir.coordinate_of base operand has unsupported type");
----------------
Nit: Notifymatch failure


================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:2249
+            mlir::LLVM::LLVMPointerType::get(lowerTy().convertType(seqTy));
+        auto nxtOpnd = operands[i];
+        auto memObj = rewriter.create<mlir::LLVM::BitcastOp>(loc, seqRefTy,
----------------
Nit: remove auto?


================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:2254
+        objectTy = seqTy.getType(getFieldNumber(seqTy, nxtOpnd));
+        auto llvmCty = lowerTy().convertType(objectTy);
+        auto gep = rewriter.create<mlir::LLVM::GEPOp>(
----------------
Nit: remove auto?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114159/new/

https://reviews.llvm.org/D114159