[PATCH] D114159: [flang][codegen] Add a conversion for `fir.coordinate_of` - part 1

Andrzej Warzynski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 18 06:11:48 PST 2021


awarzynski added inline comments.


================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:2273
+
+// ----> DELETEME
+struct LenParamIndexOpConversion
----------------
PLEASE SKIP THIS BLOCK

@rovka will send a separate patch for `LenParamIndexOpConversion`. I've only added it here to be able to test this.


================
Comment at: flang/test/Fir/convert-to-llvm.fir:400
 // CHECK-LABEL: llvm.func @fir_complex_add(
-// CHECK-SAME:                             %[[ARG0:.*]]: !llvm.struct<(f128, f128)>, 
+// CHECK-SAME:                             %[[ARG0:.*]]: !llvm.struct<(f128, f128)>,
 // CHECK-SAME:                             %[[ARG1:.*]]: !llvm.struct<(f128, f128)>) -> !llvm.struct<(f128, f128)> {
----------------
I'll fix these trailing white-spaces in a separate patch and then rebase.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114159/new/

https://reviews.llvm.org/D114159



More information about the llvm-commits mailing list