[PATCH] D114155: [LoopAccessAnalysis][SVE] Bail out for scalable vectors

[David Sherwood via Phabricator via llvm-commits]

david-arm added inline comments.


================
Comment at: llvm/test/Analysis/LoopAccessAnalysis/scalable-vector-regression-tests.ll:22
+define i1 @regression_test_scalable_loop_access_typesize() {
+  br i1 false, label %2, label %1
+1:
----------------
Is it possible to clean this test up a bit here?

i.e. do something like:

  entry:
    br label %vector.body

  vector.body:
    %ind = phi i64 [ 0, %entry ], [ %ind.next, %vector.body ]
    ...
    %ind.next = add i64, %ind, 1
    br i1 %cmp, %vector.body, %end

  end:
    ret i1 false

I'm just a bit worried about the strength of the test given the `br i1 false` and `br i1 true` lines in here. Also, having proper named labels like `vector.body` or `loop.body` makes it a bit more readable I think.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114155/new/

https://reviews.llvm.org/D114155