[PATCH] D114125: [Flang] Add a factory class for creating Complex Ops

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan updated this revision to Diff 388147.
kiranchandramohan marked 3 inline comments as done.
kiranchandramohan added a comment.

Address review comments.
Mark two functions as const, simplify a function by calling another,
provide an example.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114125/new/

https://reviews.llvm.org/D114125

Files:
  flang/include/flang/Optimizer/Builder/Complex.h
  flang/include/flang/Optimizer/Builder/FIRBuilder.h
  flang/lib/Optimizer/Builder/CMakeLists.txt
  flang/lib/Optimizer/Builder/Complex.cpp
  flang/lib/Optimizer/Builder/FIRBuilder.cpp
  flang/unittests/Optimizer/Builder/ComplexTest.cpp
  flang/unittests/Optimizer/CMakeLists.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D114125.388147.patch
Type: text/x-patch
Size: 13281 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211118/87f2403a/attachment-0001.bin>