[PATCH] D112143: [X86][ABI] Do not return float/double from x87 registers when x87 is disabled

Phoebe Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 17 19:32:26 PST 2021


pengfei added a comment.

Thanks for the review!



================
Comment at: llvm/test/CodeGen/X86/no-ret-in-x87-reg.ll:147-150
+; NOX87-NEXT:    fldt {{[0-9]+}}(%esp)
+; NOX87-NEXT:    fldt {{[0-9]+}}(%esp)
+; NOX87-NEXT:    faddp %st, %st(1)
+; NOX87-NEXT:    fstpt (%esp)
----------------
nickdesaulniers wrote:
> :(
Will fix it as a follow up. D100091 aims to fix these problems.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112143/new/

https://reviews.llvm.org/D112143



More information about the llvm-commits mailing list