[PATCH] D112940: Add a tool for diffing instruction count + stack size remarks

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 17 16:50:48 PST 2021


mehdi_amini added inline comments.


================
Comment at: llvm/tools/llvm-remark-size-diff/RemarkSizeDiff.cpp:239
+              ": Expected '" + ExpectedKeyName + "', got '" + KeyName + "'"));
+  int64_t Val;
+  auto ValStr = Remark.Args[ArgIdx].Val;
----------------
You need to use `long long` for this variable to match the signature of getAsSignedInteger apparently


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112940/new/

https://reviews.llvm.org/D112940



More information about the llvm-commits mailing list