[PATCH] D114065: [Bazel] Set the right default for LLVM_WINDOWS_PREFER_FORWARD_SLASH on Windows

Wed Nov 17 15:36:36 PST 2021

GMNGeoffrey added inline comments.

================
Comment at: utils/bazel/llvm-project-overlay/llvm/config.bzl:39
     "HAVE_UNISTD_H=1",
     "LLVM_WINDOWS_PREFER_FORWARD_SLASH=0",
 ]
----------------
mstorsjo wrote:
> GMNGeoffrey wrote:
> > mstorsjo wrote:
> > > GMNGeoffrey wrote:
> > > > So this is a noop? Maybe we should just leave it off then entirely then? There's also some housekeeping stuff that didn't get done in the commit you referenced. We usually keep track of the options in https://github.com/llvm/llvm-project/blob/main/utils/bazel/llvm-project-overlay/llvm/include/llvm/Config/config.h as well. They're either set directly there or it mentions that they're defined in Bazel. This whole system needs to be reworked, but better to stay consistent for now. If you wouldn't mind removing mentions of `LLVM_WINDOWS_PREFER_FORWARD_SLASH` in this file and adding it in the approrpiatel place in the config.h overlay file, that would be great (otherwise, I'll get to it at some point)
> > > Well if you could take care of it, I'd appreciate it - I don't use Bazel myself, I just spotted that this new option was ported from cmake to Bazel in a possibly unintended way - I've been trying to reach out in other ways before, without reaction :-)
> > > 
> > > I.e., feel free to commandeer this revision or handle it otherwise - but good to have gotten your attention!
> > Ah well most appreciated then, thank you! I will take care of it :-) What were the other methods you tried for communication? I don't think I saw any messages
> I commented on the commit on GitHub (https://github.com/llvm/llvm-project/commit/7d323dc7738e3152c4bd54a23ac27554bfbbf583) and tried mailing Tres directly. Normally I would have replied to the mail on llvm-commits if nothing else, but commits that only touch the bazel directory didn’t seem to go there.
Ah yeah. I'm not sure anyone follows GitHub commit comments. I thought Bazel phab reviews go to llvm-commits now. At least this one did. But it looks like direct commits don't :-/ Anyway, thanks for raising this :-)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114065/new/

https://reviews.llvm.org/D114065