[PATCH] D114112: [SCEVAA] Avoid forming malformed pointer diff expressions
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 17 12:13:03 PST 2021
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
In D114112#3138430 <https://reviews.llvm.org/D114112#3138430>, @efriedma wrote:
> Do we have some documentation that indicates what we expect alias() to return in the case where instructionCouldExistWitthOperands fails?
I guess this is sort of out of scope; we're making the queries, and they seem to return something vaguely sane.
================
Comment at: llvm/test/Analysis/ScalarEvolution/scev-aa.ll:306
+; dominated by the first. As a result of that, we can nest the
+; addrecs and cancel out the %data base pointer.
+define void @test_dom(double* %data) {
----------------
"%addr1" here represents the value of the address in the last iteration of the first subloop? Should SCEVAA try to canonicalize the SCEV with getSCEVAtScope() or something like that to get more precise results?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114112/new/
https://reviews.llvm.org/D114112
More information about the llvm-commits
mailing list