[PATCH] D113756: [fir] Add fir.embox conversion

[Valentin Clement via Phabricator via llvm-commits]

clementval added inline comments.


================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:1471
+    if (isDerivedTypeWithLenParams(boxTy))
+      TODO(embox.getLoc(),
+           "fir.embox codegen of derived with length parameters");
----------------
kiranchandramohan wrote:
> Notify failure and testcase.
switch to `notifyMatchFailure`. Testcase cannot be added at this time because the TypeConverter will trigger a TODO before we can reach this point. 


================
Comment at: flang/test/Fir/convert-to-llvm.fir:1360
+
+// Check `fir.embox` conversion of a type code.
+
----------------
kiranchandramohan wrote:
> Is the logical type missing?
Not really missing. I didn't add test for every possible typecode. Added one for logical. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113756/new/

https://reviews.llvm.org/D113756