[PATCH] D113534: [lld-macho] Avoid warning on -install-name if -dylib is not provided

[Nico Weber via Phabricator via llvm-commits]

thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.

This lg, thanks. (Either as-is or with s/warn-no/no-warn/)

Please make sure the first line of the commit isn't "[lld-macho] Avoid warning on -install-name if -dylib is not provided" but something updated when committing. ("[lld-macho] Add flag to disable warning on pointless -install_name" or similar)



================
Comment at: lld/MachO/Options.td:76
     HelpText<"Optimize output file size">;
+def warn_no_dylib_install_name: Joined<["--"], "warn-no-dylib-install-name">,
+    HelpText<"Do not warn on -install-name if -dylib is not passed (default)">,
----------------
int3 wrote:
> I think `no-warn` makes a lot more sense than `warn-no` here
> 
> (btw, LLD-ELF's Options.td has a macro thing to define both the "yes" and "no" versions of a flag. We can consider that as we add more of these.
`--warn-no` kind of matches clang's `-Wno`, which seems vaguely nice to me. But no strong preference.

`no-warn` kind of matches ld64's various `-warn_no_` flags, which also seems vaguely nice :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113534/new/

https://reviews.llvm.org/D113534