[PATCH] D111904: [RISCV] Lower vector CTLZ_ZERO_UNDEF/CTTZ_ZERO_UNDEF by converting to FP and extracting the exponent.

[Fraser Cormack via Phabricator via llvm-commits]

frasercrmck added a comment.

LGTM too other than nits. Thanks, @craig.topper!



================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:634
+
+      // Lower CTLZ_UNDEF if we have a floating point type that can represent
+      // the value exactly.
----------------
Could maybe update this comment to use the actual ISD names for both nodes we're dealing with.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:864
+
+        // Lower CTLZ_UNDEF if we have a floating point type that can represent
+        // the value exactly.
----------------
Same here as above.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:2354
+
+  // Make sure the float type is legal. If not, fallback to expand.
+  // TODO: Splitting may make sense in some cases.
----------------
This comment seems stale since we're no longer falling back.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111904/new/

https://reviews.llvm.org/D111904