[PATCH] D113526: [InstCombine] Generalize complex OR patterns to AND

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 17 05:33:57 PST 2021


spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp:1733
+  // (~(A | B) & C) | ... --> ...
+  // (~(A & B) | C) | ... --> ...
+  // TODO: One use checks are conservative. We just need to check that a total
----------------
Typo: the left (first/inner) opcode should match the right (last/outer) opcode:
// (~(A & B) | C) & ... --> ...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113526/new/

https://reviews.llvm.org/D113526



More information about the llvm-commits mailing list