[PATCH] D112143: [X86][ABI] Do not return float/double from x87 registers when x87 is disabled

Phoebe Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 17 00:38:10 PST 2021


pengfei added inline comments.


================
Comment at: llvm/lib/Target/X86/X86CallingConv.td:279
+  CCIfNotSubtarget<"hasX87()",
+    CCIfType<[f32], CCAssignToReg<[EAX, EDX, ECX]>>>,
   CCIfType<[f16], CCAssignToReg<[XMM0,XMM1,XMM2]>>,
----------------
nickdesaulniers wrote:
> Is there a test case that exercises the assignment to %ecx?
Add one test case for it, though I don't believe we can really generate it from frontend.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112143/new/

https://reviews.llvm.org/D112143



More information about the llvm-commits mailing list