[PATCH] D112940: Add a tool for diffing instruction count + stack size remarks

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

In D112940#3136809 <https://reviews.llvm.org/D112940#3136809>, @jhenderson wrote:

> In D112940#3135470 <https://reviews.llvm.org/D112940#3135470>, @paquette wrote:
>
>> Add the tool to the lit tool substitutions. (Not sure if this is the correct way to do this, let's see!)
>
> I think what you've done is right, but apparently it's not the issue.
>
> I just noticed that all the failures are on debian machines, but I think there's also Windows machines that run the pre-merge checks. This could be a red-herring though. Sorry, I'm out of further ideas.

Ignore what I just said there about Windows. For some reason, some parts aren't showing up, but the Windows ones are failing in the same way. On further inspection of the build log, the reason that the tool isn't being found is because for whatever reason, it isn't being built, based on my reading of the log at least. Again, I'm not sure why. I'd blame something in cmake, but I don't know why you wouldn't see the failure locally in this case.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112940/new/

https://reviews.llvm.org/D112940