[PATCH] D110616: [Legalizer] Expand BR_CC into SETCC if condition code is legal

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:3562
                          Node->getOperand(2));
+      Results.push_back(Tmp1);
     } else {
----------------
qiucf wrote:
> craig.topper wrote:
> > Why did the push_backs need to be moved?
> Here when `BR_CC` is not legal, `Results` should be empty.
If it's not legal, won't we go to the else which will always push something to Results?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110616/new/

https://reviews.llvm.org/D110616