[PATCH] D113132: [InstCombine] Fuse checks for LHS (~(A | B) & C) | ... NFC.

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added a comment.

In D113132#3118870 <https://reviews.llvm.org/D113132#3118870>, @spatel wrote:

> In D113132#3117026 <https://reviews.llvm.org/D113132#3117026>, @rampitec wrote:
>
>> With all that said it looks like these patterns have to be extracted into a separate function and called for both 'or' and 'and'. But I don't think this shall preclude this NFC and the next D113141 <https://reviews.llvm.org/D113141> to wait for it, these are mostly orthogonal to me.
>
> I agree (just wanted to raise the idea of generalizing if possible) - this one looks like good cleanup / NFC. LGTM.

This is both grouping and generalizing: D113526 <https://reviews.llvm.org/D113526>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113132/new/

https://reviews.llvm.org/D113132