[PATCH] D112012: [benchmarks] Move libcxx's fork of google/benchmark and llvm/utils' under third-party

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 16 16:43:06 PST 2021


mtrofin added a comment.

In D112012#3136264 <https://reviews.llvm.org/D112012#3136264>, @sivachandra wrote:

> In D112012#3136155 <https://reviews.llvm.org/D112012#3136155>, @mtrofin wrote:
>
>> Oh! Huh, missed that. Probably my ninja check-all didn’t build the
>> benchmarks. I’ll patch shortly. Sorry for the lapse.
>
> I have already fixed the libc build.

Oh - thanks.

(For some reason I'm getting messages out of order) should we revert though your fix until I reland this - the revert due to Fuchsia's build failure seems to be due to the way they ingest CMakeLists.txt


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112012/new/

https://reviews.llvm.org/D112012



More information about the llvm-commits mailing list