[PATCH] D110616: [Legalizer] Expand BR_CC into SETCC if condition code is legal

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 16 16:34:05 PST 2021


craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:3562
                          Node->getOperand(2));
+      Results.push_back(Tmp1);
     } else {
----------------
Why did the push_backs need to be moved?


================
Comment at: llvm/test/CodeGen/PowerPC/f128-branch-cond.ll:7
+
+define i32 @test_choice1(fp128 %a, fp128 %b) {
+; P8-LABEL: test_choice1:
----------------
Add nounwind attribute to these test cases to get rid of the .cfi* directives


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110616/new/

https://reviews.llvm.org/D110616



More information about the llvm-commits mailing list