[PATCH] D113931: [fir] Add fir.box_tdesc conversion

Kiran Chandramohan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 16 15:56:31 PST 2021


kiranchandramohan accepted this revision.
kiranchandramohan added a comment.
This revision is now accepted and ready to land.

LGTM.

Is this feature complete? From docs this op seems to be for Fortran 2003 select type. Also the related gentypedesc was marked todo.



================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:468
 
+/// Lower `fir.box_tdesc` to the sequence of operation to extract the type
+/// descriptor from the box.
----------------
Nit: operation -> operations


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113931/new/

https://reviews.llvm.org/D113931



More information about the llvm-commits mailing list