[PATCH] D113756: [fir] Add fir.embox conversion

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan added a comment.

A few minor comments.



================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:169
+  // Get the element type given an LLVM type that is of the form
+  // [llvm.ptr](llvm.array|llvm.struct)+ and the provided indexes.
+  static mlir::Type getBoxEleTy(mlir::Type type,
----------------
Nit: array|struct|vector


================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:1471
+    if (isDerivedTypeWithLenParams(boxTy))
+      TODO(embox.getLoc(),
+           "fir.embox codegen of derived with length parameters");
----------------
Notify failure and testcase.


================
Comment at: flang/test/Fir/convert-to-llvm.fir:1360
+
+// Check `fir.embox` conversion of a type code.
+
----------------
Is the logical type missing?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113756/new/

https://reviews.llvm.org/D113756