[PATCH] D114002: [LoopVectorize] Check the number of uses of an FAdd before classifying as ordered

[Dave Green via Phabricator via llvm-commits]

dmgreen added a comment.

Thanks for putting together the fix.

I don't remember why the LoopExitValue needs a single user for InLoopReductions. It should have one Phi use, and only other uses outside loop, but I don't think it really needs to be a single user unless I'm missing something.

The underlying issue seems to be that AddReductionVar returns a reduction, whereas getReductionOpChain cannot find the chain. Are there more situations that could happen? Would it be better to somehow detect that getReductionOpChain will fail to find the chain?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114002/new/

https://reviews.llvm.org/D114002