[PATCH] D114017: [lld-macho][nfc] Factor-out NFC changes from main __eh_frame diff

Greg McGary via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 16 14:32:45 PST 2021


gkm marked 2 inline comments as done.
gkm added inline comments.


================
Comment at: lld/MachO/InputFiles.cpp:694
 
-    InputSection *lastIsec = subsections.back().isec;
+    Subsection subsec = subsections.back();
+    InputSection *lastIsec = subsec.isec;
----------------
oontvoo wrote:
> (dont think it's necessary to copy it)
Copying is only necessary to prevent 13 test cases from crashing ... 😵‍💫🤮


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114017/new/

https://reviews.llvm.org/D114017



More information about the llvm-commits mailing list