[PATCH] D113971: [fir] Add conversion patterns for slice, shape, shapeshift and shift ops

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan accepted this revision.
kiranchandramohan added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:1473
+/// Conversion pattern for operation that must be dead. The information in these
+/// operations is used by other operation. At this point they should not have
+/// anymore uses.
----------------
Nit: If it is the pre-codegen pass that ensures this then it might be good to mention that here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113971/new/

https://reviews.llvm.org/D113971