[PATCH] D114022: [scudo] Fix MTE crash in storeEndMarker.

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 16 12:45:22 PST 2021


eugenis added inline comments.


================
Comment at: compiler-rt/lib/scudo/standalone/combined.h:1169
     uptr UntaggedEnd = untagPointer(End);
-    if (UntaggedEnd != BlockEnd) {
+    uptr UntaggedBlockEnd = untagPointer(BlockEnd);
+    if (UntaggedEnd != UntaggedBlockEnd) {
----------------
pcc wrote:
> pcc wrote:
> > Can we fix the caller to untag BlockEnd instead?
> ...which we already did in D105261. I reckon we'll need to cherry-pick that everywhere.
Oh right. I hacked this on an older version of the code :(



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114022/new/

https://reviews.llvm.org/D114022



More information about the llvm-commits mailing list