[PATCH] D113290: [AArch64TargetMachine] Enable LICM Hosting LOAD only optimization in case of -O3
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 16 10:37:55 PST 2021
efriedma added a comment.
Not sure why you want to turn it on specifically for aarch64, and only late in the optimization pipeline.
================
Comment at: llvm/lib/Transforms/Scalar/LICM.cpp:336
+Pass *llvm::createLICMPass(bool TryHoistingLoadOnly) {
+ EnableLoadHoistOnly = TryHoistingLoadOnly;
+ return new LegacyLICMPass();
----------------
You can't mess with a global variable like this; among other issues, it breaks thread safety. If you need a variable, add a member to the LegacyLICMPass class.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113290/new/
https://reviews.llvm.org/D113290
More information about the llvm-commits
mailing list