[PATCH] D98232: [regalloc] Ensure Query::collectInterferringVregs is called before interval iteration

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added a comment.

Hi Mircea,

> If not (the argument goes), let's yank out the old code.

I thought x86 was using that code, but I see that you actually disabled that back in March:

  commit ce61def529e2d9ef46b79c9d1f489d69b45b95bf
  Author: Mircea Trofin <mtrofin at google.com>
  Date:   Mon Mar 8 20:55:53 2021 -0800
  
      [regalloc] Ensure Query::collectInterferringVregs is called before interval iteration



> If not (the argument goes), let's yank out the old code.

Sounds like a plan.

> Or does the envisioned patch require most of the stuff that's currently 'dead'?

No, the "envisioned patch" actually runs a post regalloc pass that does the clean up.

Cheers,
-Quentin


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98232/new/

https://reviews.llvm.org/D98232