[PATCH] D25618: Check that emitted instructions meet their predicates on all targets except ARM, Mips, and X86.

[Jay Foad via Phabricator via llvm-commits]

foad added a comment.
Herald added subscribers: kerbowa, pengfei, atanasyan, jrtc27, fedor.sergeev, kbarton, kristof.beyls, arichardson, jvesely, sdardis.
Herald added a project: LLVM.

Sorry for commenting on such an old patch but I am wondering why was `verifyInstructionPredicates` implemented inside of `MCCodeEmitter`? In practice this seem to mean that `llc -filetype=obj` gets this checking but `llc -filetype=asm` (the default, as used by almost all lit codegen tests) does not. Would it be possible to move `verifyInstructionPredicates` somewhere a bit more generic so that both paths can get this checking?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D25618/new/

https://reviews.llvm.org/D25618