[PATCH] D113554: Delete code comments for impossible bugs

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 16 08:53:26 PST 2021


reames requested changes to this revision.
reames added a comment.
This revision now requires changes to proceed.

What prevents:
base = some alloc
%iv = {0, +, 1} as i8
%gep = getelementptr i32, i32 *%base, i8 %iv

I would strongly prefer to see *test cases* which cover the piece you think is impossible.  Otherwise, we're both having to reason about possibilities in code.  An example helps to make that reasoning much more concrete.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113554/new/

https://reviews.llvm.org/D113554



More information about the llvm-commits mailing list