[PATCH] D113534: [lld-macho] Avoid warning on -install-name if -dylib is not provided

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 16 07:56:56 PST 2021


thakis added a comment.

The patch generally looks good, but I'd probably also add a `--warn-dylib-install-name` to override the no form, name the config variable to use the positive name ("don't use no double negation") and mention "[--warn-dylib-install-name]" in the warning text so that users know the warning is toggleable (like clang does).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113534/new/

https://reviews.llvm.org/D113534



More information about the llvm-commits mailing list