[compiler-rt] d0c138e - tsan: disable bench_threads.cpp on aarch64

Dmitry Vyukov via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 16 07:53:14 PST 2021


Author: Dmitry Vyukov
Date: 2021-11-16T16:53:04+01:00
New Revision: d0c138ec8aa47ec2acb38dba247f537ca470618f

URL: https://github.com/llvm/llvm-project/commit/d0c138ec8aa47ec2acb38dba247f537ca470618f
DIFF: https://github.com/llvm/llvm-project/commit/d0c138ec8aa47ec2acb38dba247f537ca470618f.diff

LOG: tsan: disable bench_threads.cpp on aarch64

The new test started failing on bots with:

CHECK failed: tsan_rtl.cpp:327 "((addr + size)) <= ((TraceMemEnd()))"
   (0xf06200e03010, 0xf06200000000) (tid=4073872)

https://lab.llvm.org/buildbot#builders/179/builds/1761

This is a latent bug in aarch64 virtual address space layout,
there is not enough address space to fit traces for all threads.
But since the trace space is going away with the new tsan runtime
(D112603), disable the test.

Reviewed By: melver

Differential Revision: https://reviews.llvm.org/D113990

Added: 
    

Modified: 
    compiler-rt/test/tsan/bench_threads.cpp

Removed: 
    


################################################################################
diff  --git a/compiler-rt/test/tsan/bench_threads.cpp b/compiler-rt/test/tsan/bench_threads.cpp
index 1d0be21eb5c6..d0ba42e29d8a 100644
--- a/compiler-rt/test/tsan/bench_threads.cpp
+++ b/compiler-rt/test/tsan/bench_threads.cpp
@@ -4,6 +4,11 @@
 // bench.h needs pthread barriers which are not available on OS X
 // UNSUPPORTED: darwin
 
+// aarch64 fails with:
+// CHECK failed: tsan_rtl.cpp:327 "((addr + size)) <= ((TraceMemEnd()))"
+// TODO: try to re-enable when D112603 is landed.
+// XFAIL: aarch64
+
 #include "bench.h"
 
 void *nop_thread(void *arg) {


        


More information about the llvm-commits mailing list