[PATCH] D113674: [flang] Add missing `HasParent` to `fir_DTEntryOp`
Andrzej Warzynski via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 16 07:41:40 PST 2021
This revision was automatically updated to reflect the committed changes.
Closed by commit rG50acc6d0f7dd: [flang][fir] Add missing `HasParent` in `fir_DTEntryOp` (authored by awarzynski).
Changed prior to commit:
https://reviews.llvm.org/D113674?vs=386504&id=387639#toc
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113674/new/
https://reviews.llvm.org/D113674
Files:
flang/include/flang/Optimizer/Dialect/FIROps.td
flang/test/Fir/convert-to-llvm-invalid.fir
Index: flang/test/Fir/convert-to-llvm-invalid.fir
===================================================================
--- flang/test/Fir/convert-to-llvm-invalid.fir
+++ flang/test/Fir/convert-to-llvm-invalid.fir
@@ -93,3 +93,10 @@
%0 = fir.gentypedesc !fir.type<derived3>
return
}
+
+// -----
+
+// Verify that `fir.dt_entry` requires a parent op
+
+// expected-error at +1{{'fir.dt_entry' op expects parent op 'fir.dispatch_table'}}
+fir.dt_entry "method", @method_impl
Index: flang/include/flang/Optimizer/Dialect/FIROps.td
===================================================================
--- flang/include/flang/Optimizer/Dialect/FIROps.td
+++ flang/include/flang/Optimizer/Dialect/FIROps.td
@@ -2870,7 +2870,7 @@
}];
}
-def fir_DTEntryOp : fir_Op<"dt_entry", []> {
+def fir_DTEntryOp : fir_Op<"dt_entry", [HasParent<"DispatchTableOp">]> {
let summary = "map entry in a dispatch table";
let description = [{
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D113674.387639.patch
Type: text/x-patch
Size: 932 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211116/8013cc04/attachment.bin>
More information about the llvm-commits
mailing list