[PATCH] D113763: [flang][CodeGen] Transform `fir.boxchar_len` to a sequence of LLVM MLIR

[Andrzej Warzynski via Phabricator via llvm-commits]

awarzynski added inline comments.


================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:1464
+    mlir::LLVM::ExtractValueOp len = genExtractValueWithIndex(
+        loc, boxChar, boxChar.getType(), rewriter, ctx, 1);
+    mlir::Value lenAfterCast = integerCast(loc, rewriter, returnValTy, len);
----------------
clementval wrote:
> nit: maybe having a constexpr with a proper name could help here instead of 1 or maybe a small comment. 
That's a good point - I'll update before merging.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113763/new/

https://reviews.llvm.org/D113763