[PATCH] D113971: [fir] Add conversion patterns for slice, shape, shapeshift and shift ops

[Valentin Clement via Phabricator via llvm-commits]

clementval added inline comments.


================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:1394
+    if (!op->getUses().empty())
+      return mlir::emitError(op.getLoc(), "op must be dead");
+    rewriter.eraseOp(op);
----------------
kiranchandramohan wrote:
> Should this be a notify failure?
Yeah can switch to notifyMatchFailure. I'll add a invalid test as well. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113971/new/

https://reviews.llvm.org/D113971