[PATCH] D109131: [GlobalISel] Add a store-merging optimization pass and enable for AArch64.

[Mikael Holmén via Phabricator via llvm-commits]

uabelho added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/LoadStoreOpt.cpp:39
+#include <algorithm>
+#include <any>
+
----------------
fhahn wrote:
> uabelho wrote:
> > fhahn wrote:
> > > aemerson wrote:
> > > > uabelho wrote:
> > > > > I noticed that this buildbot failed on this include:
> > > > > https://lab.llvm.org/buildbot/#/builders/110/builds/7989
> > > > > 
> > > > > We see similar problems downstream in our own private bots:
> > > > > ```
> > > > > 06:37:16 ../lib/CodeGen/GlobalISel/LoadStoreOpt.cpp:39:10: fatal error: 'any' file not found
> > > > > 06:37:16 #include <any>
> > > > > 06:37:16          ^~~~~
> > > > > 06:37:16 1 error generated.
> > > > > ```
> > > > > We get that when compiling with clang 8.0
> > > > Is this a problem with your C++ library? It should be there as part of C++17 support.
> > > I think LLVM only requires C++14, not C++17, so this probably needs to use something else.
> > From llvm/docs/CMake.rst:
> > 
> > ```
> > **CMAKE_CXX_STANDARD**:STRING
> >   Sets the C++ standard to conform to when building LLVM.  Possible values are
> >   14, 17, 20.  LLVM Requires C++ 14 or higher.  This defaults to 14.
> > ```
> > and when I get the compilation error I see
> > ```
> > -std=c++14 
> > ```
> > on the command line so we do compile with C++14.
> Looks like Amara already removed the include and the bot is back to green: https://lab.llvm.org/buildbot/#/builders/110/builds/7995
> 
> Thanks!
Yep, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109131/new/

https://reviews.llvm.org/D109131