[PATCH] D113858: [llvm-reduce] Allow writing temporary files as bitcode.

[Florian Hahn via Phabricator via llvm-commits]

fhahn updated this revision to Diff 387569.
fhahn added a comment.
Herald added a subscriber: thopre.

In D113858#3131872 <https://reviews.llvm.org/D113858#3131872>, @dblaikie wrote:

> In D113858#3131850 <https://reviews.llvm.org/D113858#3131850>, @fhahn wrote:
>
>> In D113858#3131845 <https://reviews.llvm.org/D113858#3131845>, @dblaikie wrote:
>>
>>> Would be good to have some testing - I guess it might look like the testing that was done before it was switched over to `FileCheck` - but I forget /exactly/ how awkward that was.
>>
>> There are a couple of tests that still use a python script from the `Inputs` directory. But I am not sure how to pass the path to `llvm-as` to the script? :(
>
> If the script took the path as an argument, then the test would pass the argument via `--test-arg llvm-as` - I think `lit` will do the substitution there...

Ah great, I missed that there's `--test-arg` to pass multipel options through to the test script. I updated the patch with a python script to run llvm-dis and then FileCheck on the output. I'm planning on landing this once the pre-commit tests come back ok.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113858/new/

https://reviews.llvm.org/D113858

Files:
  llvm/test/tools/llvm-reduce/Inputs/llvm-dis-and-filecheck.py
  llvm/test/tools/llvm-reduce/temporary-files-as-bitcode.ll
  llvm/tools/llvm-reduce/deltas/Delta.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D113858.387569.patch
Type: text/x-patch
Size: 3798 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211116/da487d8d/attachment.bin>