[PATCH] D113733: [llvm-objdump/mac] Add support for new load commands

[James Henderson via Phabricator via llvm-commits]

jhenderson added a subscriber: grimar.
jhenderson added a comment.

In D113733#3133226 <https://reviews.llvm.org/D113733#3133226>, @keith wrote:

> Update test

Yes, that's what I meant (Phabricator has the ability to suggest edits directly in the code, as part of a comment; this is called an "inline edit").

In D113733#3133848 <https://reviews.llvm.org/D113733#3133848>, @MaskRay wrote:

> I wish there is a way to create a test with less boilerplate. For ELF program headers, we can test many program header types in one test.
> For Mach-O, we currently need one large test for each load command...

Agreed - Macho-O's yaml2obj is badly in need of some love, like @grimar gave to the ELF version some time ago. The main thing that needs adding is making most parts optional, with sensible defaults.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113733/new/

https://reviews.llvm.org/D113733