[PATCH] D112116: [llvm-objcopy] Add --update-section

Tue Nov 16 00:45:03 PST 2021

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

I was just thinking about whether it would be useful to have an additional test case that shows that the section after a shortened not-in-segment section is moved to compress space (and therefore remaining bytes are overwritten. I'm not 100% certain it's needed, so up to you.

Otherwise, LGTM.

================
Comment at: llvm/test/tools/llvm-objcopy/ELF/update-section.test:28
+
+## Ensure the data that was in a shortened section is still retained. For cases where
+## there are gaps in segments not covered by sections, the existing contents are preserved.
----------------

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112116/new/

https://reviews.llvm.org/D112116