[PATCH] D113733: [llvm-objdump/mac] Add support for new load commands

Mon Nov 15 15:30:19 PST 2021

keith added inline comments.

================
Comment at: llvm/test/tools/llvm-objdump/MachO/lc-chained-fixups.test:1
+RUN: yaml2obj %p/Inputs/chained-fixups.yaml > %t
+RUN: llvm-objdump -p %t | FileCheck %s
----------------
jhenderson wrote:
> It's more common in newer test cases (at least the ones I work on) to use the inlined edit.
> 
> The main advantage is that when copying this line into PowerShell (something I do sometimes when debugging tests), I don't end up with weirdness around encoding (PowerShell `>` performs UTF-16 encoding).
> It's more common in newer test cases (at least the ones I work on) to use the inlined edit.

What is "the inlined edit"? Did you mean swapping `>` for `-o`? Did that if so

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113733/new/

https://reviews.llvm.org/D113733